Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ME Storage Bus prevents ME Drive from saving data. #5849

Closed
RubyRezal opened this issue Dec 22, 2021 · 0 comments · Fixed by #5856
Closed

ME Storage Bus prevents ME Drive from saving data. #5849

RubyRezal opened this issue Dec 22, 2021 · 0 comments · Fixed by #5856
Labels
bug Self explanatory?

Comments

@RubyRezal
Copy link

Describe the bug

Minecraft 1.18.1
Fabric 0.12.12
AE2 10.0.0-alpha.8

ME Drives fail to save data when an ME Storage Bus is attached.

How to reproduce the bug

Create a basic ME storage network: Creative Energy Cell, ME Smart Cable, ME Terminal, ME Drive, 1k Item Storage Cell or Portable Storage Cell

Place a ME Storage Bus on any unoccupied side of the ME Drive.
ME Storage Bus does not need to be powered or connected to anything else.

Add or remove items in the ME storage network through the ME Terminal and check to see if changes are saved to storage cells while the ME Storage Bus is attached.

Expected behavior

ME Drive should save changes to storage cells when changes are made at the ME Terminal.

Additional details

No response

Which minecraft version are you using?

1.18

On which mod loaders does it happen?

Fabric

Crash log

https://pastebin.com/GRwd1kgf
@RubyRezal RubyRezal added the bug Self explanatory? label Dec 22, 2021
shartte added a commit that referenced this issue Dec 23, 2021
@shartte
Fixes #5849: Maintain object identity in the storage adapter snapshot.
27c5ef6
@shartte shartte mentioned this issue Dec 23, 2021
Merged
shartte added a commit that referenced this issue Dec 23, 2021
@shartte
Fixes #5849: Reimplement how we handle transactions / change notifica…
763e4a5 
…tions in the Fabric storage adapter. It now properly maintains referential equality of stacks after aborted transactions.
Technici4n pushed a commit that referenced this issue Dec 23, 2021
@shartte
Maintain object identity in the storage adapter snapshot (#5856)
a0af648 
* Fixes #5849: Maintain object identity in the storage adapter snapshot.

* Fixes #5849: Reimplement how we handle transactions / change notifications in the Fabric storage adapter. It now properly maintains referential equality of stacks after aborted transactions.
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Self explanatory?
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Maintain object identity in the storage adapter snapshot AppliedEnergistics/Applied-Energistics-2
1 participant
@RubyRezal