Crafts appear to never end client side on terminal when relogging

[Swedz]

Describe the bug

Sometimes crafts will remain at the pinned row of a terminal for some players on a multiplayer server even though it has completed.

How to reproduce the bug

• Be on multiplayer
• Request a craft from a network (ideally something that takes about half a minute, but long enough that you can do the following steps without any issue)
• Log out
• Wait for the craft to complete
• Join back

Expected behavior

The crafting process to complete and not stay pinned to the top of the terminal.

Additional details

I have only tested this on fabric

Which minecraft version are you using?

1.19

On which mod loaders does it happen?

Fabric

Crash log

N/A

[shartte]

Yes, there's sadly no way to "re-validate" a crafting job once the server has been left by the client.

We need to clear pending jobs from the client when they re-join a server. We may potentially check once if the craft is still active and keep it.

The reason this is so tricky: the crafting jobs only exist in the Crafting CPU multiblock. If the chunk containing that gets unloaded, the crafting job no longer exists for the grid. But it does come back into existence when the chunk reloads.

[CinnamonShaey]

also happens on forge sadly, a fix or a way/keybind to manually "unpin" crafts would be nice

[Technici4n]

An idea might be to store crafts completed while a player was offline, and send the completion packets once it logs back on.

On the other hand, this is useless if the player has closed Minecraft, so that would waste quite some storage space... Checking available jobs would probably work too, but doesn't feel great.

We should probably just clear the list when the player joins a server.