New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority GUI improvements #3592

Merged
merged 2 commits into from Jul 8, 2018

Conversation

Projects
None yet
3 participants
@fscan
Member

fscan commented Jul 6, 2018

IProrityHost now allows the GUI to always show an icon to return to the original GUI

fscan added some commits Jul 6, 2018

@orod-org

This comment has been minimized.

orod-org commented Jul 6, 2018

SonarQube analysis reported 62 issues

  • CRITICAL 17 critical
  • MAJOR 32 major
  • MINOR 12 minor
  • INFO 1 info

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL GuiPriority.java#L182: Reduce the number of conditional operators (6) used in the expression (maximum allowed 3). rule
  2. CRITICAL DualityFluidInterface.java#L355: The Cyclomatic Complexity of this method "usePlan" is 13 which is greater than 10 authorized. rule
  3. CRITICAL DualityFluidInterface.java#L377: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  4. CRITICAL DualityFluidInterface.java#L404: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  5. CRITICAL DualityFluidInterface.java#L457: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  6. CRITICAL DualityFluidInterface.java#L608: Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation. rule
  7. CRITICAL PartFluidStorageBus.java#L285: The Cyclomatic Complexity of this method "getInternalHandler" is 15 which is greater than 10 authorized. rule
  8. CRITICAL PartFluidStorageBus.java#L332: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  9. CRITICAL DualityInterface.java#L623: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  10. CRITICAL DualityInterface.java#L632: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule

@yueh yueh added this to the rv6.alpha - 1.12 milestone Jul 7, 2018

@fscan fscan merged commit eb4caaa into rv6-1.12 Jul 8, 2018

3 of 4 checks passed

sonarqube SonarQube reported 62 issues, with 17 critical
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins Success
Details

@fscan fscan deleted the feature-improve-priority-host branch Jul 14, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment