Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Platform#postChanges to check all registered channels #3644

Merged
merged 2 commits into from Jul 31, 2018
Merged

Fix Platform#postChanges to check all registered channels #3644

merged 2 commits into from Jul 31, 2018

Conversation

fscan
Copy link
Member

@fscan fscan commented Jul 23, 2018

No description provided.

orod-org
orod-org reviewed Jul 23, 2018
View reviewed changes
src/main/java/appeng/util/Platform.java
{
is.setStackSize( -is.getStackSize() );
myInv.getAvailableItems( myChanges );
for( final IAEStack is : myChanges )
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CRITICAL Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule

@fscan fscan added this to the rv6.alpha - 1.12 milestone Jul 25, 2018
orod-org
orod-org reviewed Jul 25, 2018
View reviewed changes
src/api/java/appeng/api/storage/IStorageHelper.java
* @param addedCell the added cell itemstack
* @param src the action source
*/
void postChanges( @Nonnull final IStorageGrid gs, @Nonnull final ItemStack removedCell, @Nonnull final ItemStack addedCell, @Nonnull final IActionSource src );
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Redundant 'final' modifier. rule
MINOR Redundant 'final' modifier. rule
MINOR Redundant 'final' modifier. rule
MINOR Redundant 'final' modifier. rule

orod-org
orod-org reviewed Jul 25, 2018
View reviewed changes
src/api/java/appeng/api/storage/IStorageHelper.java
@@ -116,4 +118,15 @@
* @return items not inserted or {@code null} if everything was inserted.
*/
<T extends IAEStack<T>> T poweredInsert( final IEnergySource energy, final IMEInventory<T> inv, final T input, final IActionSource src, final Actionable mode );
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MINOR Redundant 'final' modifier. rule
MINOR Redundant 'final' modifier. rule
MINOR Redundant 'final' modifier. rule
MINOR Redundant 'final' modifier. rule
MINOR Redundant 'final' modifier. rule

@orod-org
Copy link

SonarQube analysis reported 37 issues

  • CRITICAL 6 critical
  • MAJOR 12 major
  • MINOR 18 minor
  • INFO 1 info

Watch the comments in this conversation to review them.

Top 10 extra issues

Note: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:

  1. CRITICAL IStorageHelper.java#L87: Remove usage of generic wildcard type. rule
  2. CRITICAL Platform.java#L517: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  3. CRITICAL Platform.java#L1488: The Cyclomatic Complexity of this method "extractItemsByRecipe" is 21 which is greater than 10 authorized. rule
  4. CRITICAL Platform.java#L1506: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  5. CRITICAL Platform.java#L1522: Refactor this code to not nest more than 3 if/for/while/switch/try statements. rule
  6. MAJOR Platform.java#L517: Merge this if statement with the enclosing one. rule
  7. MAJOR Platform.java#L578: Remove this useless assignment to local variable "itemStack". rule
  8. MAJOR Platform.java#L634: Remove this useless assignment to local variable "itemStack". rule
  9. MAJOR Platform.java#L1161: This branch's code block is the same as the block for the branch on line 1157. rule
  10. MAJOR Platform.java#L1209: A "NullPointerException" could be thrown; "possible" is nullable here. rule

@fscan fscan merged commit 390ad87 into rv6-1.12 Jul 31, 2018
@fscan fscan deleted the fix-postChanges branch July 31, 2018 22:27
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@orod-org orod-org orod-org left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
rv6.alpha - 1.12
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fscan @orod-org