Backport Model Registration Changes #4647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixes #4575 by updating Forge (ModelRegistryEvent is a modbus event but was misflagged as not being one). And update Forge because their breaking change breaks our mod. * Update gradle.properties Co-authored-by: yueh <yueh@users.noreply.github.com> * Update src/main/resources/META-INF/mods.toml Co-authored-by: yueh <yueh@users.noreply.github.com> Co-authored-by: yueh <yueh@users.noreply.github.com> (cherry picked from commit 8733c2c)
(cherry picked from commit 00d4c20)
yueh
approved these changes
Aug 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This backports the model registration changes from 1.16, which means we register our model loaders inside the model registry event, and not later.
(Also contains the pom.xml change so we can immediately push a release after)
Hopefully fixes #4634