Fix #6194 by making the ME Annihilation Plane enchantable #6203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shartte
reviewed
Apr 24, 2022
Since they're all applied to a fake tool used by the plane, the tool might as well have them all applied regardless of how useful they are for the plane. Also helps accommodate for other mods adding enchantments without requiring extra integration.
Technici4n
approved these changes
May 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussions on the Discord server regarding the addition of a Fortune annihilation plane, it was eventually decided that since the annihilation plane internally makes use of a fake vanilla pickaxe or other digging tool to break blocks, it should simply be enchantable in the same way as that vanilla tool would be.
planes.mp4
enchantment.mp4
As implemented, this approach allows for immediate support for any enchantments added by other mods which may affect resulting block drops, such as automatic smelting, allowing for specialised processing of items such as glass products. Furthermore, it supports enchantments of an arbitrary level without the need to hard-code anything into the plane as was previously done only for Silk Touch, e.g. a Fortune VII plane in a large modpack with mods like Apotheosis. Hence, the Identity Annihilation Plane has been made redundant and is subsequently
removeddeprecated by this PR.As an initial balancing attempt, this comes with an energy multiplier of 8 times the sum of all applied enchantment levels - subject to change depending on balance in large packs, potentially to be switched to an exponential increase depending on specific enchantments.
Further enhancements to be considered include displaying the enchanted sheen on the face of the plane when placed as a cable part and a tooltip to indicate enchantability.
Closes #6194.