Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #6289: Add powered/unpowered states to ME IO and Spatial IO ports #6290

Merged
merged 8 commits into from
May 24, 2022

Conversation

62832
Copy link
Member

@62832 62832 commented May 21, 2022

Might need confirmation on whether or not this is enough.

Copy link
Member

@Technici4n Technici4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not going to work since it I don't see any server -> client syncing. Would it make sense to have a different model for each state to properly test this? (+ for a more logical look)

@62832
Copy link
Member Author

62832 commented May 22, 2022

Presumably a new model would have some brighter lights on the base texture as a separate overlay for the sake of emissives, but I'd be lying if I said I knew as of now how to go about this.

Gone with the approach of separate textures for on/off.

@62832 62832 changed the title Fix #6289: Add LIGHTS_ON block state to IO port Fix #6289: Add powered/unpowered states to ME IO and Spatial IO ports May 24, 2022
@Technici4n Technici4n merged commit df5353a into AppliedEnergistics:master May 24, 2022
@62832 62832 deleted the fix-6289 branch May 24, 2022 12:30
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants