Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change amount setting logic #6457

Merged
merged 1 commit into from Jul 30, 2022
Merged

change amount setting logic #6457

merged 1 commit into from Jul 30, 2022

Conversation

rlnt
Copy link
Contributor

@rlnt rlnt commented Jul 25, 2022

fixes #6455

This PR changes the behavior of the NumberEntryWidget.

Button Press:
When the current value is 1 and one of the positive amount buttons is pressed, it will use the value of the button without adding the initial value of 1 to it. You will get 100 instead of 101 when you press the 100 button.
I check for % 10 so only necessary buttons are taken into account and to keep the scrolling behavior.

Minimum Changes:
When a screen defines a minimum for the widget, there is now a check if the new value falls below the minimum and will set the new value to the minimum instead. This avoid having negative values or a 0 value in a crafting request sub screen which would block the next button and makes no sense.

I made sure the scrolling behavior, manual adjustment of the value and all the buttons still work.
Here is a video of the new behavior.

@shartte shartte merged commit 7061ac5 into AppliedEnergistics:master Jul 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set counter to 10,100,1000 when requesting crafted amounts
2 participants