Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6455
This PR changes the behavior of the
NumberEntryWidget
.Button Press:
When the current value is 1 and one of the positive amount buttons is pressed, it will use the value of the button without adding the initial value of 1 to it. You will get 100 instead of 101 when you press the 100 button.
I check for
% 10
so only necessary buttons are taken into account and to keep the scrolling behavior.Minimum Changes:
When a screen defines a minimum for the widget, there is now a check if the new value falls below the minimum and will set the new value to the minimum instead. This avoid having negative values or a 0 value in a crafting request sub screen which would block the next button and makes no sense.
I made sure the scrolling behavior, manual adjustment of the value and all the buttons still work.
Here is a video of the new behavior.