Allow Memory Cards to Copy Upgrades & Filters #6638
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Save & Restore Upgrade Cards (prioritizes network tool) - Partially restore settings to incompatible machines
Technici4n
reviewed
Sep 30, 2022
| if (!cards.isEmpty()) { | ||
| overflow = upgrades.addItems(cards); | ||
| if (!overflow.isEmpty()) { | ||
| player.getInventory().placeItemBackInInventory(overflow); |
There was a problem hiding this comment.
Not a fan of this as it silently moves the items around in the inventory afaict.
There was a problem hiding this comment.
It's not great, but it shouldn't happen (tm) since I do simulate first if the upgrade inventory has enough space. And since they usually are quite simple, I hope that doesn't produce errors. This is just here to not void the cards in ANY case.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the ability to memory cards to:
Fixes #1382
Fixes #6633