Remove Platform Random, use Level Random wherever applicable #7685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shartte
reviewed
Feb 28, 2024
| @@ -359,7 +358,8 @@ public boolean addHitEffects(BlockState state, Level level, HitResult target, | |||
| CableBusRenderState renderState = cb.getRenderState(); | |||
|
|
|||
| // Spawn a particle for one of the particle textures | |||
| TextureAtlasSprite texture = Platform.pickRandom(cableBusModel.getParticleTextures(renderState)); | |||
| var textures = cableBusModel.getParticleTextures(renderState); | |||
| var texture = textures.get(level.getRandom().nextInt(textures.size())); | |||
There was a problem hiding this comment.
We should probably keep a util-method in Platform, but make it take the random source.
What do you think?
There was a problem hiding this comment.
That might work, though I figured it was probably worth just stripping that away altogether since the only place that method was used is in this class.
shartte
reviewed
Feb 28, 2024
| @@ -246,7 +246,7 @@ public void breakCluster() { | |||
| } | |||
|
|
|||
| for (var entry : inv.list) { | |||
| var position = places.get(Platform.getRandomInt() % places.size()); | |||
| var position = places.get(Math.abs(level.getRandom().nextInt()) % places.size()); | |||
There was a problem hiding this comment.
This is probably also a place for randomly chosing an element (?)
There was a problem hiding this comment.
You'd be right. That method could probably be brought back, then.
shartte
added a commit
that referenced
this pull request
Apr 1, 2024
shartte
added a commit
that referenced
this pull request
Apr 1, 2024
shartte
added a commit
that referenced
this pull request
Apr 2, 2024
shartte
added a commit
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #7684.