New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use FakePlayerFactory instead of our own (buggy) FakePlayer cache #7727

Merged

shartte merged 1 commit into main from fix-7724

Mar 9, 2024

Member

Technici4n commented Mar 9, 2024 •

edited

The weak hash map leaks because the keys are referenced by the values.
We only cache by level and not by GameProfile, which means that in multiplayer a fake player might have the wrong game profile if someone made one earlier.

Fixes #7724.


          Use FakePlayerFactory instead of our own (buggy) FakePlayer cache

8cfa68f

shartte merged commit 9280568 into main

6 checks passed

shartte deleted the fix-7724 branch

March 9, 2024 11:44

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment