Remove the dependency on go-logger. Define an interface in this library #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eranharel
reviewed
Oct 22, 2019
| @@ -0,0 +1,78 @@ | |||
| package log | |||
There was a problem hiding this comment.
Up to this change I was OK with the abstraction.
Here is where I'm starting to get uncomfortable... IDK
There was a problem hiding this comment.
Yeah...
The thing is - that you need some default logger for when your user did not set a logger at all, right?
|
This MR is no longer relevant due to #17 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.