Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract metric to own module #32

Merged
merged 14 commits into from Feb 2, 2021
Merged

Extract metric to own module #32

merged 14 commits into from Feb 2, 2021

Conversation

bivas
Copy link

@bivas bivas commented Jan 27, 2021 •
edited

Remove all metrics reporting from main module.
At the moment, we implement opencencus metrics reporting using the CheckListener solution.

New API

  • Added HealthListener to enable events when results are updated
  • It's now possible to register multiple CheckListeners
  • Option API now supports registering CheckListeners and HealthListeners
  • OpenCencus Specific
    • Ability to set metrics classification when creating listener

Breaking Changes

  • Added OnCheckRegistered to CheckListener - this will enable actions when check is registered with the service. e.g. resetting metrics in opencencus

Discussion in #24

@bivas bivas changed the title WIP: Extract metric to own module Extract metric to own module Jan 27, 2021
@bivas bivas mentioned this pull request Jan 27, 2021
Closed
eranharel
eranharel suggested changes Jan 28, 2021
View reviewed changes
health.go Outdated Show resolved Hide resolved
utils.go Outdated Show resolved Hide resolved
utils.go Outdated Show resolved Hide resolved
utils.go Outdated Show resolved Hide resolved
health.go Show resolved Hide resolved
opencencus-check-listener/options.go Outdated Show resolved Hide resolved
opencencus-check-listener/types.go Outdated Show resolved Hide resolved
opencencus-check-listener/utils.go Outdated Show resolved Hide resolved
options.go Outdated Show resolved Hide resolved
options.go Outdated Show resolved Hide resolved
@eranharel
Copy link
Contributor

README.md needs to be updated too

sagikazarmark
sagikazarmark suggested changes Jan 28, 2021
View reviewed changes
health_listener.go Show resolved Hide resolved
opencencus-check-listener/check_listener.go Outdated Show resolved Hide resolved
opencencus-check-listener/check_listener.go Outdated Show resolved Hide resolved
sagikazarmark
sagikazarmark reviewed Jan 28, 2021
View reviewed changes
README.md Show resolved Hide resolved
opencencus/go.mod Outdated Show resolved Hide resolved
@sagikazarmark sagikazarmark mentioned this pull request Feb 2, 2021
Closed
sagikazarmark
sagikazarmark suggested changes Feb 2, 2021
View reviewed changes
Copy link
Contributor

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had a few more ideas and suggestions, but overall 👍

go.sum Outdated Show resolved Hide resolved
health.go Show resolved Hide resolved
health.go Show resolved Hide resolved
health.go Outdated Show resolved Hide resolved
opencensus/metrics_listener.go Show resolved Hide resolved
opencensus/metrics_listener.go Show resolved Hide resolved
options.go Show resolved Hide resolved
options.go Show resolved Hide resolved
@eranharel
Copy link
Contributor

Merging, cause the rest of the comments are either minor or controversial.
I like this PR, but I see that we have a lot of work to get this project to the next level.
Thanks @bivas and @sagikazarmark I really appreciate your help

@eranharel eranharel merged commit 7a9c0f9 into AppsFlyer:master Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sagikazarmark sagikazarmark sagikazarmark requested changes

@eranharel eranharel eranharel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bivas @eranharel @sagikazarmark