Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check interface refactors #40

Merged
merged 4 commits into from May 10, 2021
Merged

Check interface refactors #40

merged 4 commits into from May 10, 2021

Commits on May 10, 2021

  1. refactor: move the Check interface back to the root module 

    Fundamentally, the Check interface belongs to the root
package as it's the main consumer of that contract.

It also felt wrong to depend on the checks package
as it contains implementations of that interface.

Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
    @sagikazarmark
    sagikazarmark committed May 10, 2021
    Configuration menu
    Copy the full SHA
    074e7b9 View commit details
    Browse the repository at this point in the history

  2. refactor: make health tests external to avoid import cycle 

    Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
    @sagikazarmark
    sagikazarmark committed May 10, 2021
    Configuration menu
    Copy the full SHA
    467cd6c View commit details
    Browse the repository at this point in the history

  3. refactor: use gosundheit.Check interface in the checks package 

    Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
    @sagikazarmark
    sagikazarmark committed May 10, 2021
    Configuration menu
    Copy the full SHA
    237a71c View commit details
    Browse the repository at this point in the history

  4. refactor!: remove unused Check interface 

    Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
    @sagikazarmark
    sagikazarmark committed May 10, 2021
    Configuration menu
    Copy the full SHA
    e81b819 View commit details
    Browse the repository at this point in the history