Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add toplevel ssl opts #17

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

reutsharabani
Copy link

@reutsharabani reutsharabani commented May 18, 2023

Adds common ssl configuration as toplevel params

@hoplers
Copy link

hoplers commented May 24, 2023

Personally I think that adding top-level configuration properties for Ketu is redundant, and that top-level configuration should be kept only for mandatory configuration (e.g brokers, group-id).
Having properties as top-level requires us to copy the configurations from Kafka clients, sometimes giving them different names - without any significant added value, but with the pain of needing to maintain this parity (and also sometimes having configurations both in top-level and in :internal-config).
WDYT?

@reutsharabani
Copy link
Author

Personally I think that adding top-level configuration properties for Ketu is redundant, and that top-level configuration should be kept only for mandatory configuration (e.g brokers, group-id). Having properties as top-level requires us to copy the configurations from Kafka clients, sometimes giving them different names - without any significant added value, but with the pain of needing to maintain this parity (and also sometimes having configurations both in top-level and in :internal-config). WDYT?

I tend to agree for now because no one should actually be using it manually. The best option is to generate this config using our internal libraries so the opportunity for error is small.

If people will start using SSL manually using internal-config it will have value in the sense of writing code (completion), readability, and also somewhat by validating the values conform to the spec.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants