Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always purge box cache in rhino::app() #292

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Always purge box cache in rhino::app() #292

merged 1 commit into from
Jun 14, 2022

Conversation

kamilzyla
Copy link
Collaborator

Changes

Closes #282: rhino::app() will now purge box cache the very first thing, regardless of legacy_entrypoint setting.

How to test

Try reloading the app without restarting the R session with all 4 legacy_entrypoint settings. Box cache should be purged and modules reloaded at all times.

You still need to ensure that rhino::app() re-executes: stop the application and restart it (in the same session) using "Run app" button or shiny::runApp().

Copy link
Member

@jakubnowicki jakubnowicki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kamilzyla kamilzyla merged commit 116d17b into main Jun 14, 2022
@kamilzyla kamilzyla deleted the purge-box-early branch June 14, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Purge box cache on startup regardless of legacy_entrypoint
2 participants