Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuring lintr link #588

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

radbasa
Copy link
Contributor

@radbasa radbasa commented Jun 5, 2024

Description

  • Add configuring linters link in rhino::lint_r() and the Rhino style guide.

Definition of Done

  • The change is thoroughly documented.
  • The CI passes (R CMD check, linter, unit tests, spelling).
  • Any generated files have been updated (e.g. .Rd files with roxygen2::roxygenise())

@radbasa radbasa requested a review from jakubnowicki June 5, 2024 10:32
@radbasa radbasa changed the base branch from main to release-1.8.0 June 5, 2024 10:32
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-1.8.0@2670bb3). Learn more about missing BASE report.

Current head 4a632a4 differs from pull request most recent head 27ddb81

Please upload reports for the commit 27ddb81 to get more accurate results.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-1.8.0     #588   +/-   ##
================================================
  Coverage                 ?   20.65%           
================================================
  Files                    ?        9           
  Lines                    ?      460           
  Branches                 ?        0           
================================================
  Hits                     ?       95           
  Misses                   ?      365           
  Partials                 ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jakubnowicki jakubnowicki merged commit b3ab9a4 into release-1.8.0 Jun 5, 2024
10 checks passed
@jakubnowicki jakubnowicki deleted the configuring-lintr-link branch June 5, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants