Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI #79

Merged
merged 9 commits into from
Nov 3, 2022
Merged

Update CI #79

merged 9 commits into from
Nov 3, 2022

Conversation

jakubnowicki
Copy link
Member

Link to the Issue

Closes #78
...

Definition of Done

...

How to test changes

Check GitHub Actions status: https://github.com/Appsilon/shiny.benchmark/actions/runs/3361979812

Note: tests fail for Windows. This PR is not aiming to fix that, so I suggest creating a new task for fixing Windows compatibility.

Tasks for PR author

  • Test your change and ensure there is no regression
  • Change has a corresponding issue. Ensure it is linked in GitHub
  • Author of the change opened a pull request and assigned a reviewer

General policy:

  • If applicable - add instructions for testing
  • If there’s no issue, create it. Each issue needs to be well defined and described.
  • All interaction with a user, user-facing messages, plots, reports etc. are written from the perspective of the person using or receiving it. They are understandable and helpful to this person. If a user sees an error message, there is a call to action, i.e. the user knows what to do to fix it.
  • README, other documentation and code comments that we have is updated with all information related to the change.
  • All code has been peer-reviewed before merging into any main branch
  • All changes have been merged into the main branch we use for development.
  • Continuous integration checks (linter, unit tests, integration tests) are configured and pass.
  • Optional: unit tests added for all new or changed logic.
  • All task requirements satisfied. If not describe it here. The reviewer is responsible to verify each aspect of the task.
  • Change covers only things in task. Please create new PR if you want to fix something else.

Copy link
Collaborator

@DouglasMesquita DouglasMesquita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just left a comment. Other than that it looks great to me!

@DouglasMesquita
Copy link
Collaborator

Also, it is failing in Windows and the error seems to be in the usage of cd. It appears in two files:

utils_cypress.R: "run-app" = glue("cd root && Rscript -e 'shiny::runApp(port = {port})'")
benchmark_cypress.R: "cd {project_path}; set -eu; exec yarn --cwd node performance-test"

@jakubnowicki jakubnowicki merged commit a1bc941 into develop Nov 3, 2022
@jakubnowicki jakubnowicki deleted the kuba-78-update-ci branch November 3, 2022 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more runners to the CI
2 participants