Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PoC - Introducing MobX state management - possiblity of setting up browser side interaction #39

Closed
wants to merge 3 commits into from

Conversation

filipakkad
Copy link
Contributor

@filipakkad filipakkad commented Jul 27, 2022

Based on the conversation on Slack

Introducing MobX state management library to control all the components (for now only few, e.g. Callout, Button for a PoC purposes)

See the demo app

This is not a Blueprint-specific idea so if you'll find it interesting it could be applicable in any shiny.react-based library

The things to be improved IMHO:

  1. The API of setObservable & listenTo should be changed so that it handle namespaced strings (e.g. ns("myObservable"))
  2. In the current form the initial/default state is set in each of the setObservable function. In most of the cases listenTo just listens to the change without setting anything. Perhaps it would be worth to change the
listenTo(titleText1 = NA, bodyText1 = NA)` # + you can't easily namespace the string

into

listenTo(ns("titleText1"), ns("bodyText1"))

@filipakkad filipakkad force-pushed the feature/client-side-interaction branch 2 times, most recently from 8d8ccdf to a4407cd Compare July 28, 2022 12:19
@kamilzyla
Copy link
Collaborator

I'll link the relevant Slack discussions here so they don't get lost:

  1. #tech-team
  2. #lab-blueprint

@pawelchabros pawelchabros force-pushed the feature/components-suggest branch 5 times, most recently from f7054e8 to 12bde42 Compare February 16, 2023 10:08
Base automatically changed from feature/components-suggest to main February 16, 2023 11:37
@kamilzyla
Copy link
Collaborator

Issue for this idea created in shiny.react repo. Archiving this branch under archive/2022-07-25/client-side-interaction tag and closing PR.

@kamilzyla kamilzyla closed this Feb 17, 2023
@kamilzyla kamilzyla deleted the feature/client-side-interaction branch February 17, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants