Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhino compatibility #87

Merged
merged 4 commits into from
Dec 8, 2022
Merged

Rhino compatibility #87

merged 4 commits into from
Dec 8, 2022

Conversation

jakubnowicki
Copy link
Member

Fix compatibility with rhino

Closes #86

Fixes "browser" live update functionality in Shiny applications with Shiny modules (which includes Rhino applications).

How to test?
All examples for live language change work.

@jakubnowicki jakubnowicki requested review from jakubsob and Gotfrid and removed request for jakubsob December 8, 2022 12:06
Copy link
Member

@Gotfrid Gotfrid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Added minor non-blocking comments.

R/ui.R Show resolved Hide resolved
examples/live_language_change/browser_app_modules.R Outdated Show resolved Hide resolved
examples/live_language_change/browser_app_modules.R Outdated Show resolved Hide resolved
@jakubnowicki jakubnowicki merged commit 7501873 into master Dec 8, 2022
@jakubnowicki jakubnowicki deleted the rhino-compatibility branch December 8, 2022 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix rhino compatibility
2 participants