Skip to content

Commit

Permalink
Preparation for CRAN release (#82)
Browse files Browse the repository at this point in the history
* chore: update NEWS.md

* chore: update maintainer info

* chore: add cran-comments.md

---------

Co-authored-by: Jakub Sobolewski <jakub.sobolewski@appsilon.com>
  • Loading branch information
jakubsob and Jakub Sobolewski committed May 16, 2024
1 parent dd56ed8 commit f850911
Show file tree
Hide file tree
Showing 4 changed files with 14 additions and 2 deletions.
1 change: 1 addition & 0 deletions .Rbuildignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,4 @@

^js$
_\.new\.png$
^cran-comments\.md$
4 changes: 2 additions & 2 deletions DESCRIPTION
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ Title: Tools for Using React in Shiny
Version: 0.4.0
Authors@R:
c(
person("Kamil", "Żyła", role = c("aut", "cre"), email = "opensource+kamil@appsilon.com"),
person("Jakub", "Sobolewski", role = "aut", email = "jakub.sobolewski@appsilon.com"),
person("Jakub", "Sobolewski", role = c("aut", "cre"), email = "opensource+jakub.sobolewski@appsilon.com"),
person("Kamil", "Żyła", role = "aut", email = "kamil@appsilon.com"),
person("Marek", "Rogala", role = "aut", email = "marek@appsilon.com"),
person("Appsilon Sp. z o.o.", role = "cph", email = "opensource@appsilon.com")
)
Expand Down
6 changes: 6 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
# shiny.react 0.4.0

- Upgrade React to 18.3.1:
- Replace deprecated React API. React 18 deprecates (React 19 removes) `ReactDOM.render` and `ReactDOM.unmountComponentAtNode`. `ReactDOM.createRoot` is used in place of those functions according to the [React 19 migration guide](https://react.dev/blog/2024/04/25/react-19-upgrade-guide#removed-deprecated-react-dom-apis).
- Changed rendering mechanism of React components. This change is motivated by the fact that it's impossible to call `ReactDOM.createRoot` on a container more than one time while `ReactDOM.render` allowed that. A `data-react-id` attribute is used to find and render React roots in place iterating over all nodes with `.react-data` class.

# shiny.react 0.3.0

1. Render React asynchronously and only once Shiny is fully initialized:
Expand Down
5 changes: 5 additions & 0 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
## Author comment

Submission of this version of the package breaks shiny.fluent and shiny.blueprint packages which depend on shiny.react due to the React upgrade.

The submission of shiny.react 0.4.0 will be followed by a submissions of shiny.fluent and shiny.blueprint, which will address compatibility issues.

0 comments on commit f850911

Please sign in to comment.