Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: import Shiny from module #74

Merged
merged 1 commit into from
Jul 27, 2023

Conversation

jakubsob
Copy link
Collaborator

@jakubsob jakubsob commented Jul 25, 2023

Changes

Import Shiny from a module to hide implementation details how this object is retrieved. It keeps diff smaller and allows easier control how we access Shiny object (no need to change Shiny to window.Shiny in multiple files).

@codecov-commenter
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (rmarkdown_support@17d6326). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@                 Coverage Diff                 @@
##             rmarkdown_support     #74   +/-   ##
===================================================
  Coverage                     ?   9.72%           
===================================================
  Files                        ?       5           
  Lines                        ?     144           
  Branches                     ?       0           
===================================================
  Hits                         ?      14           
  Misses                       ?     130           
  Partials                     ?       0           

@andyquinterom
Copy link
Contributor

Love these changes! Thank you so much for the suggestions.!

@andyquinterom andyquinterom merged commit 3632164 into rmarkdown_support Jul 27, 2023
1 check passed
@andyquinterom andyquinterom deleted the rmarkdown_support.kuba branch July 27, 2023 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants