-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remember page state #75
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like these changes. They solve a lot of issues. Please address outstanding minor comments.
Also, from my tests on internal server, looks like it solves #68. I was thinking of introducing backward compatibility with router and router_ui calls, but I can see that this would be difficult in the current setting, so maybe we can ignore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested locally and on R Connect, looks good now 👍
Previously all the pages were initially hidden and shown on bookmark change.
This solution have an important disadvantage:
suspendWhenHidden = FALSE
for all the inputs in order to update them.We decided to hide all the pages with
visibility: hidden
.This forces all the pages to be rendered during runtime, but between page state is remembered and not rendered again.
What's more the API is more consistent now. You should use
router$ui
instead ofrouter_ui()
androuter$server(input, output, session)
instead ofrouter(input, output, session)
.