Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing standard sliders #352

Merged
merged 2 commits into from Feb 5, 2021
Merged

Fixing standard sliders #352

merged 2 commits into from Feb 5, 2021

Conversation

ashbaldry
Copy link
Contributor

Resolving Issue #351

DoD

  • Major project work has a corresponding task. If there’s no task for what you are doing, create it. Each task needs to be well defined and described.

  • Change has been tested (manually or with automated tests), everything runs correctly and works as expected. No existing functionality is broken.

  • No new error or warning messages are introduced.

  • All interaction with a semantic functions, examples and docs are written from the perspective of the person using or receiving it. They are understandable and helpful to this person.

  • If the change affects code or repo sctructure, README, documentation and code comments should be updated.

  • All code has been peer-reviewed before merging into any main branch.

  • All changes have been merged into the main branch we use for development (develop).

  • Continuous integration checks (linter, unit tests) are configured and passed.

  • Unit tests added for all new or changed logic.

  • All task requirements satisfied. The reviewer is responsible to verify each aspect of the task.

  • Any added or touched code follows our style-guide.

dokato
dokato approved these changes Feb 5, 2021
View reviewed changes
Copy link
Contributor

@dokato dokato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@dokato dokato merged commit 5a3ef74 into Appsilon:develop Feb 5, 2021
@ashbaldry ashbaldry deleted the bugfix/slider branch March 28, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dokato dokato dokato approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ashbaldry @dokato