Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ania.update modal example #387

Merged
merged 4 commits into from Nov 3, 2021
Merged

Conversation

aniaskrzydlo
Copy link
Contributor

@aniaskrzydlo aniaskrzydlo commented Oct 19, 2021

Short description (with a reference to an issue).

Issue: #377

I think we have some mess in the functions to remove modals - removeModal() actually hides all modals, the same as remove_all_modals, while remove_modal tries to use shiny::removeUI. I will ask on Slack if and how we want to clean this up.

For now I just updated the example to hide the modal and it should work fine.

DoD

  • Major project work has a corresponding task. If there’s no task for what you are doing, create it. Each task needs to be well defined and described.

  • Change has been tested (manually or with automated tests), everything runs correctly and works as expected. No existing functionality is broken.

  • No new error or warning messages are introduced.

  • All interaction with a semantic functions, examples and docs are written from the perspective of the person using or receiving it. They are understandable and helpful to this person.

  • If the change affects code or repo sctructure, README, documentation and code comments should be updated.

  • All code has been peer-reviewed before merging into any main branch.

  • All changes have been merged into the main branch we use for development (develop).

  • Continuous integration checks (linter, unit tests) are configured and passed.

  • Unit tests added for all new or changed logic.

  • All task requirements satisfied. The reviewer is responsible to verify each aspect of the task.

  • Any added or touched code follows our style-guide.

Copy link
Contributor

@federiva federiva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks!

@federiva
Copy link
Contributor

federiva commented Nov 3, 2021

@aniaskrzydlo I have set the CI to run the tests again, feel free to merge and delete once the tests pass. 👍

@aniaskrzydlo aniaskrzydlo merged commit ff73e45 into develop Nov 3, 2021
@aniaskrzydlo aniaskrzydlo deleted the ania.update_modal_example branch November 3, 2021 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants