Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added YUYV Metadata #174

Merged
merged 4 commits into from
Feb 3, 2023
Merged

Added YUYV Metadata #174

merged 4 commits into from
Feb 3, 2023

Conversation

yashrajsapra
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #173
Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Test Results Linux-CudaT

    1 files  ±0      1 suites  ±0   12m 59s ⏱️ -1s
239 tests ±0  176 ✔️ ±0  63 💤 ±0  0 ±0 
176 runs  ±0  113 ✔️ ±0  63 💤 ±0  0 ±0 

Results for commit d0cdd28. ± Comparison against base commit 5516641.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Test Results Linux_ARM64

    1 files  ±0      1 suites  ±0   13m 24s ⏱️ ±0s
242 tests ±0  144 ✔️ ±0  98 💤 ±0  0 ±0 
144 runs  ±0    46 ✔️ ±0  98 💤 ±0  0 ±0 

Results for commit d0cdd28. ± Comparison against base commit 5516641.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

Test Results Linux

    1 files  ±0      1 suites  ±0   12m 53s ⏱️ ±0s
181 tests ±0  136 ✔️ ±0  45 💤 ±0  0 ±0 
136 runs  ±0    91 ✔️ ±0  45 💤 ±0  0 ±0 

Results for commit d0cdd28. ± Comparison against base commit 5516641.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@kumaakh kumaakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested to re arrange the code so that YUYV and UYVY cases are heandled as a fallback case statement rather than individual. please imrove.

base/include/DMAAllocator.h Show resolved Hide resolved
base/include/ImageMetadata.h Outdated Show resolved Hide resolved
base/include/RawImageMetadata.h Show resolved Hide resolved
base/include/RawImageMetadata.h Outdated Show resolved Hide resolved
base/src/DMAFDToHostCopy.cpp Show resolved Hide resolved
Copy link
Collaborator

@kumaakh kumaakh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes requested in comments mainly to merge simiar case statements

@github-actions
Copy link

github-actions bot commented Nov 12, 2022

Test Results Win-nocuda

    1 files  ±0      1 suites  ±0   12m 46s ⏱️ -1s
174 tests ±0  130 ✔️ ±0  44 💤 ±0  0 ±0 
130 runs  ±0    86 ✔️ ±0  44 💤 ±0  0 ±0 

Results for commit 993e734. ± Comparison against base commit f76afa9.

♻️ This comment has been updated with latest results.

@github-actions
Copy link

github-actions bot commented Feb 1, 2023

Test Results WSL

    1 files  ±0      1 suites  ±0   13m 4s ⏱️ ±0s
239 tests ±0  178 ✔️ ±0  61 💤 ±0  0 ±0 
178 runs  ±0  117 ✔️ ±0  61 💤 ±0  0 ±0 

Results for commit d0cdd28. ± Comparison against base commit 5516641.

@kumaakh kumaakh merged commit 855990f into main Feb 3, 2023
@kumaakh kumaakh deleted the yuyvmeta branch February 3, 2023 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Image Metadata for YUYV frame
2 participants