Baresip SIP-call VideoSink #224
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results Linux 1 files ± 0 1 suites ±0 10m 21s ⏱️ - 1m 48s Results for commit 94c7311. ± Comparison against base commit 5406509. This pull request removes 19 and adds 122 tests. Note that renamed tests count towards both.This pull request removes 5 skipped tests and adds 27 skipped tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
* added one more constructor which takes offsetvalue * refactored * intialized the nextPtrOffset * refactoring
mraduldubey
requested changes
May 23, 2023
#220) * Basic commit * overlaydatainfo class * added FrameContainerQueueOverlayAdapter class * Updated the module - zaki * added basic test and serialization * updated the overlay * serialization working - Not implemented deserialization completely * serliazation and deserilization working without save and load * updated the visitor and composite class * Added the overlayFactory pattern for the overlay * implemented Builder pattern * added internal seriliaze function for composite * seriliazation and deserialization working * Updated the seriliazeVisitor pattern * 1. Fixed the compositeOverlay primitiveType issue. 2. Serialization and deserialization working. Test passing. * implemented draw visitor and did some refactoring * refactored Overlay Module and tests * draw function working * Updated MotionExtrator module to use generic OverlayModule * removed the adapter changes * removed extra spaces * diabled simultaneous read write test * Updated the getSerialize function name * Updated the test --------- Co-authored-by: venkat0907 <venkatnallamothu0907@gmail.com>
Test Results Linux-CudaT 1 files ± 0 1 suites ±0 10m 22s ⏱️ - 1m 48s Results for commit 94c7311. ± Comparison against base commit 5406509. This pull request removes 26 and adds 159 tests. Note that renamed tests count towards both.This pull request removes 12 skipped tests and adds 64 skipped tests. Note that renamed tests count towards both.This pull request skips 1 test. |
|
@Vinayak-YB please create a new branch with these changes so that we can quickly review and merge. This one is pretty old, it will be difficult to review this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #223
Description
In this pr baresip and lib_re libraries are added as submodules in thirdparty. A sip call video sink module is written and working fine. Also a webrtc module which works on v4l2 source is included.
In base/SIP a readme for sip video call demo is added.
Type
Type Choose one: Feature
Checklist