Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed the next pointer offset condition to set data size #328

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

mohammedzakikochargi
Copy link
Collaborator

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description

Fixed the issue of data size not getting set for the 2nd time due to nextPtrOffset (condition where we were checking if the value is same is declared value) variable getting initialized while setting data size for the first time.

Alternative(s) considered

Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type

Type Choose one: (Bug fix)

Screenshots (if applicable)

Checklist

  • I have read the Contribution Guidelines
  • I have written Unit Tests
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach

Copy link

github-actions bot commented Jan 30, 2024

Test Results Linux_ARM64

  1 files  ±0    1 suites  ±0   10m 42s ⏱️ -1s
426 tests ±0  261 ✅  - 1  164 💤 ±0  1 ❌ +1 
262 runs  ±0   97 ✅  - 1  164 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit f52055d. ± Comparison against base commit 110a2e2.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 30, 2024

Test Results Linux

  1 files  ±0    1 suites  ±0   10m 25s ⏱️ ±0s
307 tests ±0  233 ✅  - 1  73 💤 ±0  1 ❌ +1 
234 runs  ±0  160 ✅  - 1  73 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit d488909. ± Comparison against base commit ba0f2ff.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jan 31, 2024

Test Results Linux-CudaT

  1 files  ±0    1 suites  ±0   10m 29s ⏱️ -1s
408 tests ±0  240 ✅  - 1  167 💤 ±0  1 ❌ +1 
241 runs  ±0   73 ✅  - 1  167 💤 ±0  1 ❌ +1 

For more details on these failures, see this check.

Results for commit d488909. ± Comparison against base commit ba0f2ff.

♻️ This comment has been updated with latest results.

Copy link
Collaborator

@joiskash joiskash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@joiskash joiskash enabled auto-merge (squash) April 16, 2024 08:23
@joiskash joiskash disabled auto-merge May 15, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants