-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added a function to reset the image size #330
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update submodule, everything else looks fine.
buf.type = V4L2_BUF_TYPE_VIDEO_OUTPUT; | ||
if (ioctl(dev_fd, VIDIOC_DQBUF, &buf) == -1) | ||
{ | ||
throw AIPException(AIP_FATAL, "cannot dqbuf video device<" + props.device); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw AIPException(AIP_FATAL, "cannot dqbuf video device<" + props.device); | |
throw AIPException(AIP_FATAL, "Cannot dqbuf video device<" + props.device); |
} | ||
if (close(dev_fd) == -1) | ||
{ | ||
throw AIPException(AIP_FATAL, "cannot close video device<" + props.device); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw AIPException(AIP_FATAL, "cannot close video device<" + props.device); | |
throw AIPException(AIP_FATAL, "Cannot close video device<" + props.device); |
// Query buffer state | ||
if (ioctl(dev_fd, VIDIOC_QUERYBUF, &buf) == -1) | ||
{ | ||
throw AIPException(AIP_FATAL, "cannot setup video device<" + props.device + ">"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
throw AIPException(AIP_FATAL, "cannot setup video device<" + props.device + ">"); | |
throw AIPException(AIP_FATAL, "Cannot setup video device<" + props.device + ">"); |
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
Added a function to reset the image size of the virtual cam device, so that processSos() hits in the next step to change the resolution of the virtual device.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Type Choose one: (Feature)
Screenshots (if applicable)
Checklist