Modified image extraction to allow for size and CSS modifiers #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Image embeds in obsidian can be modified using a pipe syntax. See: - https://forum.obsidian.md/t/resize-embedded-content/877/23 - https://www.reddit.com/r/ObsidianMD/comments/v1fs0f/centering_images_in_reading_mode/ Currently, the regex extracts all the pipes as part of the file name, which means any image modified by pipes can't be displayed in the timeline. This minor change takes the image name only before the pipe symbol to allow this.
|
Hey @oricc, thank you so much for this 🙏 |
Fixing ESLint error
|
Hey @April-Gras, thanks for the quick feedback. |
|
Perfect! Now all that is left to do is to bump the version in the Run |
|
Done 😊 |
April-Gras
approved these changes
May 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Image embeds in obsidian can be modified using a pipe syntax.
See:
Currently, the regex extracts all the pipes as part of the file name, which means any image modified by pipes can't be displayed in the timeline. This minor change takes the image name only before the pipe symbol to allow this.
An example:
![[image.png|200X200]] does not appear in the timeline in the current version but does after the change