-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Scroll to Bottom on Timeline V2 #1493
Implement Scroll to Bottom on Timeline V2 #1493
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is in need of a rename prior to merging.
(master branch) (#1492)
would look a little silly in the changelog.
Co-authored-by: April Sylph <28949509+AprilSylph@users.noreply.github.com>
Or a rename during the squash merge, but yep! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to work fine:
/dashboard
: just kept scrolling, as it would/blog/april-codes
: all 304 posts loaded, then stopped scrolling
I don't like doing that unless it's my own PRs... [Remembers I'm only reviewing your PRs, not merging them for you] Ohhhhhh yeah... |
Oh, grr, why does this not work on queue. |
Oh. Queue hasn't been migrated yet. It's probably gonna be one of the last timelines migrated, since the reordering logic. |
I tested this on a V1 timeline ( |
Yeah—I thought I just needed to add |
ooh, |
it's WHAT |
Co-Authored-By: April Sylph <28949509+AprilSylph@users.noreply.github.com>
<div class="sortableContainer"> This might make more sense if you know that Redpop uses SortableJS v1. Or it might not! I've actually touched that code a lot (attempting to upgrade it to v2; I failed) and I don't remember why it's there or like that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have a queue long enough to test the latest commit, but code LGTM, and I presume you tested it yourself.
Today I learned: I should probably make my CSS translation dev tool's output have more of a distinction between source and translated class names :D |
The way the classnames are shown in development builds of Redpop are |
Description
This implements Scroll to Bottom on V2 timelines.
As noted in the linked issue, on V2 timelines, the loader element we need to detect so that we keep scrolling conditionally:
Thus, this:
Resolves #1491.
Merge conflicts spectacularly with #977, but what can you do, I guess. (#1492, is what.)
Testing steps
not formally tested as of this pr description update; should be tested on following/followers/activity as well as post timelines
edit: tested (works, stops at end) on: