Fix event timing #108
Merged
Fix event timing #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkGeeRomano
previously approved these changes
Nov 13, 2018
cckelly
force-pushed
the
cck-fix-event-timing
branch
from
5bfa6e2
to
b710bd6
Compare
mahjiang
reviewed
Nov 13, 2018
| }) | ||
| .on('error', log => reject(log)) | ||
| }) | ||
| address = address || contractAddress |
There was a problem hiding this comment.
if address is falsy here, we should throw because it means something was up with the event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes transaction functions that rely on data from events before returning, to
awaiton the event being fired rather than receiving the transaction receipt itself, causing a race condition on slower networks.