Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverts indexing event params #135

Closed
wants to merge 2 commits into from
Closed

Reverts indexing event params #135

wants to merge 2 commits into from

Conversation

mahjiang
Copy link

Fixes #

  • Events not firing

@mahjiang mahjiang self-assigned this Nov 27, 2018
cckelly
cckelly reviewed Nov 27, 2018
View reviewed changes
constants.js Outdated Show resolved Hide resolved
cckelly
cckelly suggested changes Nov 27, 2018
View reviewed changes
Copy link
Contributor

@cckelly cckelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@mahjiang
Copy link
Author

@cckelly reverted constants back to 0.4.14

@mahjiang
Copy link
Author

#136

@mahjiang mahjiang closed this Nov 27, 2018
@mahjiang mahjiang deleted the ej_test_indexed branch November 27, 2018 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cckelly cckelly cckelly requested changes

@bplaster bplaster Awaiting requested review from bplaster

@MarkGeeRomano MarkGeeRomano Awaiting requested review from MarkGeeRomano

Assignees

@mahjiang mahjiang

Labels
Regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mahjiang @cckelly