Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ej tests #144

Merged
merged 56 commits into from
Dec 12, 2018
Merged

Ej tests #144

merged 56 commits into from
Dec 12, 2018

Conversation

mahjiang
Copy link

@mahjiang mahjiang commented Dec 6, 2018

Fixes #

Proposed Changes

@mahjiang mahjiang self-assigned this Dec 6, 2018
@mahjiang mahjiang force-pushed the ej_tests branch 2 times, most recently from b2ed898 to d826e3b Compare December 10, 2018 20:26
library.js Outdated Show resolved Hide resolved
ownership.js Show resolved Hide resolved
purchase.js Show resolved Hide resolved
purchase.js Show resolved Hide resolved
registry.js Show resolved Hide resolved
registry.js Show resolved Hide resolved
rewards.js Show resolved Hide resolved
test/ownership.js Outdated Show resolved Hide resolved
Copy link
Contributor

@cckelly cckelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing documentation for the new ownership functions in the README, also need to rename commerce in there to ownership. Looks good otherwise, killed it on these tests!

cckelly
cckelly previously approved these changes Dec 12, 2018
Copy link
Contributor

@cckelly cckelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@cckelly cckelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@mahjiang mahjiang merged commit 0e80152 into master Dec 12, 2018
@mahjiang mahjiang deleted the ej_tests branch December 12, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants