Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ej factory #171

Merged
merged 21 commits into from
Jan 3, 2019
Merged

Ej factory #171

merged 21 commits into from
Jan 3, 2019

Conversation

mahjiang
Copy link

@mahjiang mahjiang commented Jan 2, 2019

Proposed Changes

  • Add contracts/ source files to .npmignore
  • Refactor migrations scripts to deploy AraFactory contract before deploying core contracts and AFS Standard
  • Add factory.js

@mahjiang mahjiang self-assigned this Jan 2, 2019
@mahjiang mahjiang requested a review from cckelly January 2, 2019 23:08
@mahjiang mahjiang added the enhancement New feature or request label Jan 2, 2019
cckelly
cckelly reviewed Jan 3, 2019
View reviewed changes
constants.js Show resolved Hide resolved
cckelly
cckelly reviewed Jan 3, 2019
View reviewed changes
contracts/AraFactory.sol Outdated Show resolved Hide resolved
cckelly
cckelly reviewed Jan 3, 2019
View reviewed changes
factory.js Outdated Show resolved Hide resolved
cckelly
cckelly reviewed Jan 3, 2019
View reviewed changes
factory.js Show resolved Hide resolved
cckelly
cckelly reviewed Jan 3, 2019
View reviewed changes
bin/act-deploy Outdated Show resolved Hide resolved
cckelly
cckelly suggested changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@cckelly cckelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

cckelly
cckelly previously approved these changes Jan 3, 2019
View reviewed changes
Copy link
Contributor

@cckelly cckelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tight

@mahjiang mahjiang merged commit 6f36b2b into master Jan 3, 2019
@mahjiang mahjiang deleted the ej_factory branch January 3, 2019 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cckelly cckelly cckelly approved these changes

Assignees

@mahjiang mahjiang

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mahjiang @cckelly