Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(bin/*): remove custom help catches, use yargs #172

Merged
merged 2 commits into from
Nov 19, 2018

Conversation

cckelly
Copy link
Contributor

@cckelly cckelly commented Nov 19, 2018

Fixes #169

mahjiang
mahjiang previously approved these changes Nov 19, 2018
Copy link

@mahjiang mahjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍌

Copy link

@mahjiang mahjiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🇹🇼

@cckelly cckelly merged commit a95b5a6 into master Nov 19, 2018
@cckelly cckelly deleted the cck-yargs-help branch November 19, 2018 17:53
"extends": "ara"
"extends": "ara",
"rules": {
"no-unused-vars": [2, {"vars": "all", "varsIgnorePattern": "argv" }]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think my rule here is justified haha, you can't remove argv entirely because yargs needs it to run the command.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely. That one has always given me trouble and I always hated the way refactors turned out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants