Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update doctrine annotation usage to avoid memory leaks #4

Closed
wants to merge 1 commit into from
Closed

Update doctrine annotation usage to avoid memory leaks #4

wants to merge 1 commit into from

Conversation

mikeSimonson
Copy link

@mikeSimonson mikeSimonson mentioned this pull request Dec 10, 2017
Closed
@mikeSimonson
Copy link
Author

I just don't know why travis fails. I can't reproduce the failure locally and it seems like it failed a while ago.

@enumag
Copy link
Member

enumag commented Dec 10, 2017

Travis fails because of BC break in PHPUnit. I will work when next version of Codeception is out.

@enumag
Copy link
Member

enumag commented Dec 10, 2017 •
edited

Also I don't think this change is necessary. The registerLoader method is only called for tests of this package so it won't affect your application.

This could be relevant for Kdyby/Annotations though. Could you send a PR there?

@mikeSimonson
Copy link
Author

@enumag will do

@enumag
Copy link
Member

enumag commented Dec 10, 2017

Thanks!

@enumag enumag closed this Dec 10, 2017
@f3l1x f3l1x mentioned this pull request Dec 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mikeSimonson @enumag