-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package should expose 'normalise' as well #1
Comments
Oh, that's really reasonable. Now I feel silly for having exported a function instead of an object... Dare I try something hacky like hanging a function on another function, to preserve backwards-compatibility? Or maybe just a major version bump... |
Personally, I think a major version bump would be fine at this point. If
you do that, I can dump a couple of deps from ethereum-ens and depend on
this instead. :)
…On Fri, May 5, 2017 at 6:23 PM Dan Finlay ***@***.***> wrote:
Oh, that's really reasonable. Now I feel silly for having exported a
function instead of an object... Dare I try something hacky like hanging a
function on another function, to preserve backwards-compatibility? Or maybe
just a major version bump...
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABFyW6KZSit8YJJ8MVVx0_L886hJK8rks5r21sugaJpZM4NSMMb>
.
|
Ok, doing that now. |
danfinlay
added a commit
that referenced
this issue
May 5, 2017
Is a major breaking change, because we now export an object instead of a lone function. Fixes #1
Published to npm as |
Thanks!
…On Fri, May 5, 2017 at 6:36 PM Dan Finlay ***@***.***> wrote:
Published to npm as 2.0.0!
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABFyVZnC67I7J8MvSdAuYPFKPwIxGcvks5r2146gaJpZM4NSMMb>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Or at least, it'd be really nice if it did that.
The text was updated successfully, but these errors were encountered: