Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency on idna-uts46 causing transpiling problems for browser #5

Closed
pointtoken opened this issue Nov 5, 2017 · 2 comments
Closed

Dependency on idna-uts46 causing transpiling problems for browser #5

pointtoken opened this issue Nov 5, 2017 · 2 comments

Comments

@pointtoken
Copy link

It seems the issue raised by @Arachnid here jcranmer/idna-uts46#5 affects this library -- we can't transpile when using webpack and uglify.
@pointtoken pointtoken mentioned this issue Nov 5, 2017
Open
@manosamy
Copy link

manosamy commented Nov 15, 2017 •
edited
Loading

I forked this library as eth-ens-namehash-ms and made it to use idna-uts46-hx, also changed one more line to downgrade from ES6 to ES5, published to npm as eth-ens-namehash-ms
So that I can uglify without errors

@danfinlay
Copy link
Collaborator

Fixed by #7.

Arachnid pushed a commit that referenced this issue Sep 19, 2022
@mdtanrikulu
Merge pull request #5 from ensdomains/mdt/ascii-to-unicode
f62f351 
normalize toUnicode, version bump
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@danfinlay @manosamy @pointtoken