-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add database API endpoints to retrieve the list of databases. #30
Add database API endpoints to retrieve the list of databases. #30
Conversation
I noticed that the properties in The examples listed in the specs: Creating a database named example.
Creating a database named mydb with two users.
|
project/roadmap.md
Outdated
- [ ] GET/_api/database List of databases | ||
- [ ] POST/_api/database Create database | ||
- [X] GET/_api/database List of databases | ||
- [X] POST/_api/database Create database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have tests yet for Create database?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll answer my own question - as far as I can tell, we haven't done the proper implementation for Create database yet so we shouldn't check it off in the task list yet. Can you uncheck it for now?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep I will do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While we do not have an explicit test for create database, most (if not all) the per-test-class fixtures use the method the create a test database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the criteria for marking a task complete is that we have implemented both the endpoint and tests of the endpoint. Those methods existed for use in other tests but there are no tests explicitly for them yet.
Yes I agree. These have so far only been implemented to help with writing tests of the other endpoints, so they aren't considered "complete" yet. We should model the complete response from ArangoDB and that can be done as part of the "proper" implementation of those endpoints (i.e. when we come to implement tests for them and tick them off in our roadmap task list) |
/// available for the current user. | ||
/// </remarks> | ||
/// <returns></returns> | ||
public async Task<ListDatabaseResult> ListDatabasesAsync() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rossmills99 Maybe this should be named GetDatabasesAsync
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think I agree
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I will create a new issue for that.
#29