Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix '_key' in collection check __contains__ method #122

Merged

Conversation

duriantang
Copy link
Contributor

@duriantang duriantang commented Oct 10, 2018

This PR should close #113 #119 .

@codecov-io
Copy link

codecov-io commented Oct 10, 2018

Codecov Report

Merging #122 into master will not change coverage.
The diff coverage is 33.33%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #122   +/-   ##
=======================================
  Coverage   79.37%   79.37%           
=======================================
  Files          12       12           
  Lines        2255     2255           
=======================================
  Hits         1790     1790           
  Misses        465      465
Impacted Files Coverage Δ
pyArango/collection.py 66.35% <33.33%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74421b0...55b6abb. Read the comment docs.

@duriantang duriantang changed the title fix '_key' in collectioin check in __contains__ method fix '_key' in collectioin check __contains__ method Oct 10, 2018
@duriantang duriantang changed the title fix '_key' in collectioin check __contains__ method fix '_key' in collection check __contains__ method Oct 10, 2018
@tariqdaouda tariqdaouda merged commit 0321bb9 into ArangoDB-Community:master Oct 10, 2018
@tariqdaouda
Copy link
Collaborator

Thanks!

@duriantang duriantang deleted the fix/check_doc_in_collection branch October 10, 2018 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check if document exists
3 participants