Added Aiohttp based client, added FutureResponse to lazily load response #61
Conversation
This reverts commit 758f6a9.
Removed the restriction on FutureResponse, given that it will work with any future, not just an asyncio one. Removed the error which gets thrown in async client init, since earlier imports will fail due to the async keyword, tested the failure on version number in http_clients/__init__.py
|
Hi @dancollins34, Thank you for the PR. I've been meaning to look into asyncio myself but never had the time... so this is awesome! Just a few requests:
I appreciate your contribution! Cheers, |
commit a95effa Author: dancollins34 <dancollins34@gmail.com> Date: Sat Nov 4 22:45:13 2017 -0400 Added file rename to asyncio.py, changed returnFuture to return_future commit c056dc3 Author: dancollins34 <dancollins34@gmail.com> Date: Sat Nov 4 21:40:43 2017 -0400 Added test_update_user to increase coverage to 100% for aiohttp client commit 7d362f6 Author: dancollins34 <dancollins34@gmail.com> Date: Sat Nov 4 21:30:56 2017 -0400 Fixed the last coverage error related to FutureResponse commit 8cae98c Author: dancollins34 <dancollins34@gmail.com> Date: Sat Nov 4 21:16:09 2017 -0400 Made changes to fix travis and coverage Removed the restriction on FutureResponse, given that it will work with any future, not just an asyncio one. Removed the error which gets thrown in async client init, since earlier imports will fail due to the async keyword, tested the failure on version number in http_clients/__init__.py commit 9e32673 Author: dancollins34 <dancollins34@gmail.com> Date: Sat Nov 4 21:07:38 2017 -0400 Revert "Added tests to bring to full coverage of version exceptions" This reverts commit 758f6a9. commit 758f6a9 Author: dancollins34 <dancollins34@gmail.com> Date: Sat Nov 4 21:03:14 2017 -0400 Added tests to bring to full coverage of version exceptions commit 7d92cd0 Author: dancollins34 <dancollins34@gmail.com> Date: Sat Nov 4 20:48:16 2017 -0400 Moved utils to tests.utils, replaced references to be correct commit 5de0ab7 Author: dancollins34 <dancollins34@gmail.com> Date: Sat Nov 4 20:44:48 2017 -0400 Fixed an error in setup.py commit 60cb3e0 Author: dancollins34 <dancollins34@gmail.com> Date: Sat Nov 4 20:42:26 2017 -0400 Fixed bash math commit 1dff440 Author: dancollins34 <dancollins34@gmail.com> Date: Sat Nov 4 20:27:15 2017 -0400 Incorrect direction for versioned import commit 51e107b Author: dancollins34 <dancollins34@gmail.com> Date: Sat Nov 4 20:22:11 2017 -0400 Fixed import statement to only import asyncio client when applicable commit f5f27c2 Author: dancollins34 <dancollins34@gmail.com> Date: Sat Nov 4 20:18:58 2017 -0400 Forgot to close travis bash statement if blocks commit 6c2b2cc Author: dancollins34 <dancollins34@gmail.com> Date: Sat Nov 4 20:11:56 2017 -0400 Attempted to fix multiple test possibilities, added imports to setup.py commit 3ae18be Author: dancollins34 <dancollins34@gmail.com> Date: Sat Nov 4 19:42:41 2017 -0400 Added aiohttp based client, added FutureResponse to lazily load response attributes
|
Squashed commits. Im unsure how to change the commit messages, but I can do so in the future. All the names are now consistent and name of file changed from aio.py to asyncio.py |
- Add tests for aiohttp based client - Restrict import in http_clients.__init__.py to applicable python versions - Add FutureResponse to lazily load attributes - Move testing functions to general, py35 and py34_minus submodules
|
Fixed the commit message |
|
Hi @dancollins34, Thanks again for the PR. I've merged it to dev for now. As I am a novice when it comes to asyncio, it will take some time before I can vet the changes and push it to master branch. Meanwhile, I will update the documentation on eventlet monkey patching (thank you for pointing that out as well). Best, |
|
Realized that, although this works fine, it still will provide not performance benefits because responses are immediately accessed by the collection functions. I'll work on a refactor to remove this immediate access tonight. |
|
Hi @dancollins34, I'm currently in the process of refactoring some of the changes you've made + adding other improvements. Also it seems the commits were not squashed properly so I'm fixing that as well. This will likely result in a rebase so if you don't mind, it might be best if you wait a day or two so I can push the change to the dev branch first (at which point you will probably have to reset your local repository. Otherwise you will have to deal with git conflicts etc. Thanks, |
This adds an aiohttp asynchronous http client which uses futures. It also adds a FutureResponse object which will not automatically load responses on initialization, only on access.
Of note- The description on the wiki that you can monkey patch with requests using eventlet is incorrect. While you can do this with no issue, the fact that the default Response accesses all fields upon initialization would require waits every time the Response object was created and defeat the purpose of this.
Also to note- this only works for python>=3.5 due to the use of async await syntax. There are checks in place in the code to throw a runtime error in earlier versions