Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error: unused parameter ‘itr’ #33

Closed
wants to merge 1 commit into from

Conversation

saleyn
Copy link

@saleyn saleyn commented Jan 9, 2021

exprtk.hpp:2418:58: error: unused parameter ‘itr’ [-Werror=unused-parameter]
 2418 |          inline bool is_comment_start(details::char_cptr itr)
      |                                       ~~~~~~~~~~~~~~~~~~~^~~

exprtk.hpp:2418:58: error: unused parameter ‘itr’ [-Werror=unused-parameter]
 2418 |          inline bool is_comment_start(details::char_cptr itr)
      |                                       ~~~~~~~~~~~~~~~~~~~^~~
@ArashPartow
Copy link
Owner

Hello @saleyn

Thank-you for reporting this issue. I hadn't performed a combinatorial set of builds based around the various defines for some time, as a result this issue had gotten through.

That being said, I decided to resolve the issue a little differently, essentially making it a little more readable:

22beb73#diff-58c1983215ef11e39375e044aaa946c840e57c7f72d3ba9e303ee1a9b7cd9865R2418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants