Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #30, make navbar sticky #40

Merged
merged 19 commits into from Jul 6, 2021
Merged

Conversation

sebbekarlsson
Copy link
Contributor

Makes the navigation sticky when scrolling,
also adds "npm run lint" command to run eslint.

Copy link
Owner

@ArastoSahbaei ArastoSahbaei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kastade in lite comments!
Det framgick inte så tydligt heller, men navigationbaren kommer behöva 'krympas' när man scrollat och även addera någon form av opacity during scroll.

@ArastoSahbaei
Copy link
Owner

opacity: ${(props: Partial<{ opacity?: number }>) => props.opacity};
Det här stycket trigger re-renders när man scrollar

@ArastoSahbaei
Copy link
Owner

image
image

Navbaren blockerar dom olika vyerna

@ArastoSahbaei
Copy link
Owner

image
DropDownProfile hamnar out of sync med navbaren när navbaren går in i miniature format.
Du kan höja height något så att det passar.

@sebbekarlsson
Copy link
Contributor Author

image
image

Navbaren blockerar dom olika vyerna

Fixat

@sebbekarlsson sebbekarlsson merged commit e47804c into master Jul 6, 2021
@ArastoSahbaei ArastoSahbaei deleted the feature/sticky-scroll-#30 branch July 7, 2021 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants