Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using existing modules via new @UseModules annotation. #6

Merged
merged 4 commits into from
Mar 30, 2013

Conversation

yln
Copy link
Contributor

@yln yln commented Mar 16, 2013

Example:

@RunWith(JukitoRunner.class)
@UseModules({ FooModule.class, BarModule.class}
public class MyTest {
  // Tests methods  
}

The example is equivalent to the following inner static module class approach.

@RunWith(JukitoRunner.class)
public class MyTest {
  static class Module extends JukitoModule {
    @Override
      protected void configureTest() {
        install(new FooModule());
        install(new BarModule());
      }
    }
  // Test methods
}

@buildhive
Copy link

ArcBees » Jukito #7 FAILURE
Looks like there's a problem with this pull request
(what's this?)

@yln
Copy link
Contributor Author

yln commented Mar 16, 2013

Unfortunately I had problems with the checkstyle configuration in eclipse.
Maybe this is the reason for the failing build?

checkstyle-error

@branflake2267
Copy link
Contributor

Good job. Seems the build server is complaining about checkstyle.

@przemekgalazka
Copy link
Member

I had the same problem with checkstyle lately ...

Pozdrawiam
Przemek Gałązka

On Sat, Mar 16, 2013 at 3:42 PM, Brandon Donnelson <notifications@github.com

wrote:

Good job. Seems the build server is complaining about checkstyle.


Reply to this email directly or view it on GitHubhttps://github.com//pull/6#issuecomment-15005834
.

@christiangoudreau
Copy link
Member

This: #5 need to be merged.

@christiangoudreau
Copy link
Member

FYI, @Chris-V merged the new checkstyle config, please update your code so that we can merge this

Format new code according to checkstyle configuration.
@buildhive
Copy link

ArcBees » Jukito #9 SUCCESS
This pull request looks good
(what's this?)

@christiangoudreau
Copy link
Member

Let's move to 4/4/8 once the last two pull request gets merged @Chris-V

@yln
Copy link
Contributor Author

yln commented Mar 30, 2013

Any updates on this?

@christiangoudreau
Copy link
Member

Yes, you can merge, sorry it wasn't obvious in my last comment.

@yln yln closed this Mar 30, 2013
@yln yln reopened this Mar 30, 2013
@buildhive
Copy link

ArcBees » Jukito #10 SUCCESS
This pull request looks good
(what's this?)

christiangoudreau added a commit that referenced this pull request Mar 30, 2013
Using existing modules via new @UseModules annotation.
@christiangoudreau christiangoudreau merged commit ad5f6af into ArcBees:master Mar 30, 2013
@yln
Copy link
Contributor Author

yln commented Mar 30, 2013

Nice, thanks!
Any predictions when a version that includes this will be released?

@christiangoudreau
Copy link
Member

I'll merge the other PR, move to 4/4/8 and release a new version before eow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants