Remove most of $ constructors in favour of $(Object) #336
Conversation
manolo
force-pushed
the
mcm_fix_overload_java8
branch
from
d8688ad
to
9c5dd11
Compare
…isambiguation. Fixes issue 335
manolo
force-pushed
the
mcm_fix_overload_java8
branch
from
9c5dd11
to
d31880f
Compare
| } | ||
| if (o instanceof JavaScriptObject) { | ||
| return $((JavaScriptObject) o); | ||
| return $(((Function) o).getElement()); |
There was a problem hiding this comment.
But this method doesn't exist anymore, aren't you introducing a loop here ? Idem for the other call of $() inside this method
There was a problem hiding this comment.
ok I got it... Scratch my comment
There was a problem hiding this comment.
I'm concerned about this change for the future. It will be easy to screw up this part of code and introduce a loop. Do we have test for each that covers each possibility ?
There was a problem hiding this comment.
Will take a look to all possibilities. The problem is that this seems not fix the issue of the user, I cannot reproduce his problem though. Let see if I reach a solution to have the issue fixed. Then we can focus on reviewing this code.
There was a problem hiding this comment.
Anyway I would not release a version which fails with java8, although new gquery 2.0 is though for java8
Avoid java8 disambiguation. Fixes #335