Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Modal #9

Closed
patrickarlt opened this issue May 9, 2019 · 3 comments
Closed

Component: Modal #9

patrickarlt opened this issue May 9, 2019 · 3 comments
Assignees
@paulcpederson

Comments

@patrickarlt
Copy link
Contributor

Esri/calcite-web#1013

Also See: https://ionicframework.com/docs/api/modal
@patrickarlt
Copy link
Contributor Author

@macandcheese assigning this to you since you said you had experimented with it a little.

@macandcheese
Copy link
Contributor

macandcheese commented May 23, 2019 •
edited
Loading

We have been thinking about modals taking a "type" prop that would allow for:

  • Full page takeovers
  • Constrained page takeovers
  • Default modal (with width field - px or s/m/l)
  • Sheet modal - becomes affixed-to-bottom sheet on mobile.

Full page takeover, and constrained takeover become full screen on mobile.

"Sheet" and default modals can use status color accent bar and icon the same way alerts can to make that consistent.

Title is a prop, content is a slot for any content, and I'm undecided if we want to make footer actions a slot for buttons, or lock that down and accept only explicit "primary", "secondary", or "tertiary" slots or props.

Perhaps props for "has close" and "click on overlay to dismiss"

Thoughts?

This was referenced Jun 10, 2019
Closed
Closed
@paulcpederson paulcpederson self-assigned this Jul 24, 2019
@paulcpederson
Copy link
Member

I am going to try my hand at this today, FYI

paulcpederson added a commit to paulcpederson/calcite-components that referenced this issue Jul 30, 2019
@paulcpederson
Esri#9 - 🔲 modals
7d8a7f2
paulcpederson added a commit that referenced this issue Aug 2, 2019
@paulcpederson
#9 - 🔲 integration of calcite-buttons into modals
8055e2e
kumarGayu added a commit that referenced this issue Aug 4, 2019
@kumarGayu
Merge branch 'master' into kuma9360/date-picker
e53596d 
* master: (32 commits)
  v1.0.0-beta.2
  cleanup build process
  v1.0.0-beta.1
  minor cleanup to test master push
  #86 - remove calcite-fonts (#89)
  Update focus style
  Button style updates
  Fixes typos, adds css vars, sets element dir
  add modals to stencil config
  Prep for beta 1 release (#85)
  calcite-colors: 1.3.1
  #9 - 🔲 integration of calcite-buttons into modals
  #9 - 🔲 modals
  Ensures alerts are full width on medium viewports
  Bumps stencil version
  Updates to alerts
  Adds dir and conditional styling for icons
  Updates to address PR feedback
  Adds calcite button component
  Issue #5: Rename group event.
  ...

# Conflicts:
#	src/index.html
#	stencil.config.ts
kumarGayu added a commit that referenced this issue Aug 4, 2019
@kumarGayu
Merge branch 'master' into kumar-date-picker
e2085d7 
* master: (32 commits)
  v1.0.0-beta.2
  cleanup build process
  v1.0.0-beta.1
  minor cleanup to test master push
  #86 - remove calcite-fonts (#89)
  Update focus style
  Button style updates
  Fixes typos, adds css vars, sets element dir
  add modals to stencil config
  Prep for beta 1 release (#85)
  calcite-colors: 1.3.1
  #9 - 🔲 integration of calcite-buttons into modals
  #9 - 🔲 modals
  Ensures alerts are full width on medium viewports
  Bumps stencil version
  Updates to alerts
  Adds dir and conditional styling for icons
  Updates to address PR feedback
  Adds calcite button component
  Issue #5: Rename group event.
  ...

# Conflicts:
#	package-lock.json
#	package.json
#	src/index.html
@macandcheese macandcheese removed their assignment Aug 13, 2020
alisonailea pushed a commit that referenced this issue Aug 29, 2023
@eriklharper
Merge pull request #9 from Esri/feature/design-tokens
7674be0 
sync: feature/design-tokens to designer/brunoaires
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@paulcpederson paulcpederson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@patrickarlt @paulcpederson @macandcheese