Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed bugs in dataset #11

Merged
merged 1 commit into from
Aug 8, 2021
Merged

fixed bugs in dataset #11

merged 1 commit into from
Aug 8, 2021

Conversation

ZhiboRao
Copy link
Member

@ZhiboRao ZhiboRao commented Aug 8, 2021

No description provided.

@ZhiboRao ZhiboRao merged commit 64fe749 into master Aug 8, 2021
@sourcery-ai
Copy link

sourcery-ai bot commented Aug 8, 2021

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.53%.

Quality metrics Before After Change
Complexity 3.51 ⭐ 3.49 ⭐ -0.02 👍
Method Length 74.20 🙂 74.35 🙂 0.15 👎
Working memory 8.76 🙂 8.90 🙂 0.14 👎
Quality 65.76% 🙂 65.23% 🙂 -0.53% 👎
Other metrics Before After Change
Lines 361 379 18
Changed files Quality Before Quality After Quality Change
Source/JackFramework/Contrib/StereoMatching/PSMNet/model.py 50.06% 🙂 50.06% 🙂 0.00%
Source/JackFramework/DatasetReader/stereo_dataset.py 75.21% ⭐ 73.72% 🙂 -1.49% 👎

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
Source/JackFramework/Contrib/StereoMatching/PSMNet/model.py PSMNet.forward 7 ⭐ 382 ⛔ 11 😞 42.52% 😞 Try splitting into smaller methods. Extract out complex expressions
Source/JackFramework/Contrib/StereoMatching/PSMNet/model.py PSMNet.__init__ 6 ⭐ 297 ⛔ 10 😞 47.38% 😞 Try splitting into smaller methods. Extract out complex expressions
Source/JackFramework/DatasetReader/stereo_dataset.py StereoDataset._read_testing_data 2 ⭐ 215 ⛔ 14 😞 48.73% 😞 Try splitting into smaller methods. Extract out complex expressions
Source/JackFramework/DatasetReader/stereo_dataset.py StereoDataset._read_training_data 1 ⭐ 133 😞 12 😞 60.18% 🙂 Try splitting into smaller methods. Extract out complex expressions
Source/JackFramework/Contrib/StereoMatching/PSMNet/model.py hourglass.__init__ 0 ⭐ 160 😞 9 🙂 63.95% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@ZhiboRao ZhiboRao deleted the add_some_feature branch November 8, 2021 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant