Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix some bugs #57

Merged
merged 1 commit into from
Jan 26, 2022
Merged

fix some bugs #57

merged 1 commit into from
Jan 26, 2022

Conversation

ZhiboRao
Copy link
Member

No description provided.

@sourcery-ai
Copy link

sourcery-ai bot commented Jan 26, 2022

Sourcery Code Quality Report

✅  Merging this PR will increase code quality in the affected files by 10.90%.

Quality metrics Before After Change
Complexity 2.42 ⭐ 1.07 ⭐ -1.35 👍
Method Length 38.22 ⭐ 23.00 ⭐ -15.22 👍
Working memory 7.51 🙂 4.86 ⭐ -2.65 👍
Quality 79.82% 90.72% 10.90% 👍
Other metrics Before After Change
Lines 645 65 -580
Changed files Quality Before Quality After Quality Change
Source/JackFramework/Core/application.py 91.62% ⭐ 91.62% ⭐ 0.00%
Source/JackFramework/Evaluation/listhandler.py 89.80% ⭐ 89.86% ⭐ 0.06% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation

Legend and Explanation

The emojis denote the absolute quality of the code:

  • ⭐ excellent
  • 🙂 good
  • 😞 poor
  • ⛔ very poor

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.


Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!

@ZhiboRao ZhiboRao merged commit 42be028 into master Jan 26, 2022
@ZhiboRao ZhiboRao deleted the refator_code_in_background_jack branch March 18, 2022 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant