-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swell-Pedal an other #18
Comments
Hi Synthematophon, thanks for the feedback, I appreciate it. Regarding the issues:
Cheers, Arthur. |
Hi Arthur, thanks a lot for your patience!
1. I controll the swell (like a swellbox in a real organ) with a swell-pedal. That affects only the third manual. Using the swell-pedel with Aeolus the over-alle volume is to be changed. You understood that correct.
2. Attached is a screenshot of my setup
3. I solved the problem changing the build in IR with own ones.
4. Great!
Thanks a lot and kind regards
Burkard
Gesendet: Montag, 30. Januar 2023 um 22:36 Uhr
Von: "Arthur Benilov" ***@***.***>
An: "Archie3d/aeolus_plugin" ***@***.***>
Cc: "Synthematophon" ***@***.***>, "Author" ***@***.***>
Betreff: Re: [Archie3d/aeolus_plugin] Swell-Pedal an other (Issue #18)
Hi Synthematophon, thanks for the feedback, I appreciate it.
Regarding the issues:
How exactly do you control the swell? It seems to me that you are controlling the global plugin volume (CC7). The swell is controller by the slider on the left - one for each division. Now, there is no dedicated CC assigned to those, when used as a plugin you can attach an automation or MIDI control to those parameters to your convenience. But I understand that your use case it to play it as a standalone application. I may offer to map those parameters to CC11 (expression), will this work for your controller? The swell flag in the configuration tells whether an additional low-pass filter gets applied or not when controlling that slider on the left - it is supposed to emulate the swell box. I may revisit the swell modelling in the future.
The plugin interface normally respects the scale factor set for the display in your OS. If you think it's too small, probably your scaling is set to 100%, but then everything else should appear also quite small to you. I would be curious to see a screenshot of your setup. But otherwise, it should be possible to add a scaling. Currently the window resize is meant to accommodate more stops from the configuration, but I can add an additional scaling factor.
Yes, this should be possible. Now, when you use it as a plugin from a DAW, you can use whatever reverb you like. Moving the reverb slider to the very left will disable the internal reverb (which will also save some CPU). But again, seems like you favour the standalone usage. I may add a possibility to load custom IRs for the reverb then.
Right, there are several optimisations that I need to do in this regard. Expect the performance to improve in the next release.
Cheers,
Arthur.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Hi Arthus,
BTW i could identify the pretty high CPU load. It only occurs using IR. You wrote ( @3. :"disable the internal reverb (which will also save some CPU)"). But in reality it saves a huge amount of CPU. Incredible much.
It would be so great to implement some improvements at that point.
Thanks a lot!
Synthematophon
Gesendet: Montag, 30. Januar 2023 um 22:36 Uhr
Von: "Arthur Benilov" ***@***.***>
An: "Archie3d/aeolus_plugin" ***@***.***>
Cc: "Synthematophon" ***@***.***>, "Author" ***@***.***>
Betreff: Re: [Archie3d/aeolus_plugin] Swell-Pedal an other (Issue #18)
Hi Synthematophon, thanks for the feedback, I appreciate it.
Regarding the issues:
How exactly do you control the swell? It seems to me that you are controlling the global plugin volume (CC7). The swell is controller by the slider on the left - one for each division. Now, there is no dedicated CC assigned to those, when used as a plugin you can attach an automation or MIDI control to those parameters to your convenience. But I understand that your use case it to play it as a standalone application. I may offer to map those parameters to CC11 (expression), will this work for your controller? The swell flag in the configuration tells whether an additional low-pass filter gets applied or not when controlling that slider on the left - it is supposed to emulate the swell box. I may revisit the swell modelling in the future.
The plugin interface normally respects the scale factor set for the display in your OS. If you think it's too small, probably your scaling is set to 100%, but then everything else should appear also quite small to you. I would be curious to see a screenshot of your setup. But otherwise, it should be possible to add a scaling. Currently the window resize is meant to accommodate more stops from the configuration, but I can add an additional scaling factor.
Yes, this should be possible. Now, when you use it as a plugin from a DAW, you can use whatever reverb you like. Moving the reverb slider to the very left will disable the internal reverb (which will also save some CPU). But again, seems like you favour the standalone usage. I may add a possibility to load custom IRs for the reverb then.
Right, there are several optimisations that I need to do in this regard. Expect the performance to improve in the next release.
Cheers,
Arthur.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Hi, Since you were able to compile the plugin yourself, you can improve the reverb performance by disabling the zero-delay part of it. As result the reverb will sound about 100ms late, but in some cases this may even be more pleasant. Check how it's done for _irs.push_back({
"Elveden Hall, Suffolk",
BinaryData::elveden_hall_suffolk_england_wav,
BinaryData::elveden_hall_suffolk_england_wavSize,
0.1f,
false, // <---- Setting this flag to false disables the zero-delay part of the convolver
{}
}); But there are also other optimisations besides the reverb that I have planned, so this will improve overall. BTW, I cannot see your screenshot if you've attached any. Perhaps e-mail attachments do not go through, and you'd need to attach it in GitHub. Thanks. |
Hi, Strange enough that my generated file size (Aeolus.exe) is (almost) double the size of yours. |
Hi, please make sure you compile it in I've started adding some optimisations on the develop branch, this should improve the CPU usage a bit. |
Hi, it's o great! You are my hero! |
BTW. let me rise som other issues:
|
Hi,
|
|
Hi, Sorry, the next question: Thanks! |
Hi,
Yes, I had to reverse engineer the To produce custom stops in JSON format I have some python scripts that you can find here. These are not meant to be easy to use, mind you :) But essentially, I use the samples from the real organ pipe recordings which I then fit to the Aeolus 64-harmonic model. For that I load the samples to SPEAR software which allows extracting partials from the samples. Organ recordings are usually quite noisy I would clean the harmonics in SPEAR to leave only the nice, loud and clean ones. Then the partials can be exported from SPEAR as a text file. This text file in then read by model_fit.py script that outputs the stop Hope this clarifies things. |
Hi, |
Hi from a fully blind organist. Firstly I'm really impressed that while running this in MacOS 12.6.6 with VoiceOver, I can successfully navigate this as a standalone instrument. I'm really pleased. I find there's a few things missing that I'd like implemented within the app. 1: A Voicing Window to voice each stop, either per pipe or range based, keep up the amazing work. lew |
Hi, |
Hi,
I’d love some help with this. I started dealing with aeolus when it came to the organnery project, a total nightmare to the point where I gave in completely. Why? Linux is so poor for accessibility to the point where the screen reader built in to some versions of linux, or where it has to be custom installed, doesn’t even understand aeolus. and can’t work with it, surprising really as it was a linux based package in the first place.
It’s voiceover friendly as a standalone package, so accessibility isn’t an issue.
What I’d like to see come out of this amazing little app is the ability from within a menu to set up midi events like you can in grandorgue, hauptwerk and organteq, these setups are crucial to a midi console. Say you have a 4 manual console like I have which is a custom build , I am building the console purely myself including the cabinetry, the build consists of 2 stop jambs, left side loaded with 63 switch contacts, right loaded with 58 contact switches, 4 manuals with piston rails, pedalboard with 4 expression shoes (3 swell type, 1 crescendo) + toe studs, I’d like to build Aeolus to behave in a way that it works with the console and recognise the various specifications via midi learn as an example. so having a midi setup window where I can utilise the different midi controllers / encoder units to achieve the parameters I need, would help a heck of a lot.
at least there’s one good thing about the standalone version, you can set up the audio and midi interfaces directly, no JACK setup, thank god for that.
I’d like to have a stop system setup similar to that of a few English churches / cathedrals I’ve worked for over the years, including York Minster, Westminster Abbey, Kings College Cambridge, etc.
you mention loading custom stop libraries, are there any available and if so, how do I achieve this?
lew :)
… On 28 May 2023, at 22:52, Arthur Benilov ***@***.***> wrote:
Hi,
I am glad you were able to use it with a screen reader. The stops buttons implementation is not accessibility friendly I must admit, I will see how this could be improved. As for the rest of your points:
2. Yes, perhaps it makes sense to have an extensive MIDI configuration for the controls, but at the moment you can achieve this by mapping parameters from the DAW when using Aeolus as a plugin.
3. I am not sure what you mean for the sequencer to navigate between generals. You can already access any sequencer position either by advancing forwards or backwards (via key switches for example) or by selecting the sequencer position directly in order to recall the entire organ registration. I will check whether this works with accessibility, perhaps some improvement is needed.
4. I have not thought about divisional pistons, for now you can use the sequencer, which is also acts as general pistons I suppose. The sequencer is also controlled by the MIDI Program change (MIDI program number corresponds to the sequencer position), I am not sure what MIDI control one would need for divisional pistons.
5. You can already use custom organ configurations and have as many divisions as you need. The custom configuration is described here: https://github.com/Archie3d/aeolus_plugin#custom-organ-configuration <https://github.com/Archie3d/aeolus_plugin#custom-organ-configuration> Let me know if you need any assistance with this.
—
Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATQDNKLJTI2OUBIPRXFEADDXIPCJRANCNFSM6AAAAAAUK6KX5A>.
You are receiving this because you commented.
|
out of curiosity, I installed this on my test bed, a macbook pro 2020 16” I9 running MacOS 12.6.6. Where do I find the contents to edit, it hasn’t created a folder in my documents or my user account, so these files must be embedded or elsewhere
I was just listening to the script and it’s certainly interesting. there’s a fair bit of scope available and chance to edit some parameters.
to clarify this,
Manual 3 = Swell,
Manual 2 = Great,
Manual 1 = Choir
if this is the case, I’d look at renaming the headers and descriptions to refer to them by their traditional naming standards.
If within the scripts, I change swells for great and choir divisions to True and Tremulant to True, will this create buttons for both instances?
lew :)
… On 28 May 2023, at 22:52, Arthur Benilov ***@***.***> wrote:
Hi,
I am glad you were able to use it with a screen reader. The stops buttons implementation is not accessibility friendly I must admit, I will see how this could be improved. As for the rest of your points:
2. Yes, perhaps it makes sense to have an extensive MIDI configuration for the controls, but at the moment you can achieve this by mapping parameters from the DAW when using Aeolus as a plugin.
3. I am not sure what you mean for the sequencer to navigate between generals. You can already access any sequencer position either by advancing forwards or backwards (via key switches for example) or by selecting the sequencer position directly in order to recall the entire organ registration. I will check whether this works with accessibility, perhaps some improvement is needed.
4. I have not thought about divisional pistons, for now you can use the sequencer, which is also acts as general pistons I suppose. The sequencer is also controlled by the MIDI Program change (MIDI program number corresponds to the sequencer position), I am not sure what MIDI control one would need for divisional pistons.
5. You can already use custom organ configurations and have as many divisions as you need. The custom configuration is described here: https://github.com/Archie3d/aeolus_plugin#custom-organ-configuration <https://github.com/Archie3d/aeolus_plugin#custom-organ-configuration> Let me know if you need any assistance with this.
—
Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATQDNKLJTI2OUBIPRXFEADDXIPCJRANCNFSM6AAAAAAUK6KX5A>.
You are receiving this because you commented.
|
The default organ configuration in embedded into the plugin/executable. But you can provide your own configuration if you place You can rename the manuals if you wish and you can indeed set The current naming convention was suggested to me by another organist, so I can see there could be a degree of variability here :) |
can swells be set as individual midi controller assignments?
any thoughts on the possibility to implement a crescendo pedal function? or would this be a real pain?
lew
… On 29 May 2023, at 12:14, Arthur Benilov ***@***.***> wrote:
The default organ configuration in embedded into the plugin/executable. But you can provide your own configuration if you place organ_config.json file into your Documents/Aeolus folder as described here: https://github.com/Archie3d/aeolus_plugin#custom-organ-configuration <https://github.com/Archie3d/aeolus_plugin#custom-organ-configuration> You can start from default_organ.json from the source code, copy it to your Documents/Aeolus folder and rename to organ_config.json. You can also place the original Aeolus pipes definitions (ae0 files) in the very same folder and reference them in your custom config.
You can rename the manuals if you wish and you can indeed set tremulant and swell flags to true. This will enable the tremulant button on corresponding division and will add a swell filter accordingly. For now the default configuration has the swell being enabled only on the 3rd division, as suggested by another gentlemen in this very same discussion thread :)
The current naming convention was suggested to me by another organist, so I can see there could be a degree of variability here :)
—
Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATQDNKPPDN44AMGHUP7APETXISAI3ANCNFSM6AAAAAAUK6KX5A>.
You are receiving this because you commented.
|
Yes, you can use CC7 controller on the MIDI channel selected for the swell control (drop box to the right from the virtual keyboard). CC7 on the global control MIDI channel will affect the entire organ volume. You can assign different MIDI channels to control the volume and tremulant (mod wheel) of individual divisions. |
That’s brilliant. I look forward to putting this to test.
could a 4th manual be created? if so, do you have any stops available to initially test a 4th manual with?
lew
… On 29 May 2023, at 13:35, Arthur Benilov ***@***.***> wrote:
Yes, you can use CC7 controller on the MIDI channel selected for the swell control (drop box to the right from the virtual keyboard). CC7 on the global control MIDI channel will affect the entire organ volume. You can assign different MIDI channels to control the volume and tremulant (mod wheel) of individual divisions.
—
Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATQDNKOC6FYWTABY6NKME6TXISJ2VANCNFSM6AAAAAAUK6KX5A>.
You are receiving this because you commented.
|
Yes, fourth manual can be added in the config the same way as the existing ones, but there are no more unique stops, so you either have to copy stops referenced from other manuals or move them. Don't take pedal stops, as they have limited keys range. |
is there a way to create new pipes / stops? if so, how?
lew
… On 29 May 2023, at 16:51, Arthur Benilov ***@***.***> wrote:
Yes, fourth manual can be added in the config the same way as the existing ones, but there are no more unique stops, so you either have to copy stops referenced from other manuals or move them. Don't take pedal stops, as they have limited keys range.
—
Reply to this email directly, view it on GitHub <#18 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ATQDNKKJ6VM2TXDO2RLY2GTXITAXXANCNFSM6AAAAAAUK6KX5A>.
You are receiving this because you commented.
|
This is not a trivial process. The pipes in Aeolus are modeled by their harmonics, so once have to specify the harmonics amplitudes, envelops, detune on attack and release. All this information is stored in the pipe model file. Original Aeolus has a Linux tool that allows defining harmonics and envelopes. I was never able to find this tool, tbh. My approach to model pipes is to fit the model to the raw audio samples. This however requires some manual work as well, since the recorded samples are usually quite noisy and reverberant. Do you have any particular stops you would like to model? Do you have samples for these stops? |
Hi, another question: |
Sure, this should be possible. Requires a bit of UI work, so please stay put (see issue #30). |
Hi Archie,
Great work you are doing. I appreciate it a lot. Thanks for your intensive work!
Let me raise some issues:
Thanks a lot and kind regards
Synthematophon 8
The text was updated successfully, but these errors were encountered: